simplify call architecture + enlarge screenshares #5402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
noid/simplifyCallArchitcture
branch
2 times, most recently
from
02d5796 to
b3e4179
Compare
mahibi
changed the title
mahibi
force-pushed
the
noid/simplifyCallArchitcture
branch
from
b3e4179 to
540b336
Compare
was unused.. Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Classes related to calls are build with classic observer patterns. This is quite hard to debug and to keep an overview. This PR tries to simplify the architecture, e.g. by replacing observer patterns with kotlin flows. Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
just as temporary solution? Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
noid/simplifyCallArchitcture
branch
from
540b336 to
17424b4
Compare
Signed-off-by: Marcel Hibbe <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5402.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Simplify classes around call architecture e.g. by replacing classic observer patterns with kotlin flows.
... I just wanted to implement #1397 but came to the conclusion that the architecture should be simplified beforehand!
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x